[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676802#action_12676802
 ] 

Mahadev konar commented on ZOOKEEPER-78:
----------------------------------------

sorry for my late response tom.. i havent had a real close look at the 
interfaces and methods in this patch myself, so thanks for reviewing.. I was 
mainly looking at the handling of zookeeper events.

1)  I think you are rught that we should probably have call back methods with 
lockacruired and lockreleeased methods. The current implementation is too 
restrictive.
2) I am with you on this one as well... I hadn't implemented the lock interface 
just because I had the same reservations as you.. I think for now we should 
just leave it as it is without implementing the lock interface and see what our 
users have to say.. 
3) agreed.. 



> added a high level protocol/feature - for easy Leader Election or exclusive 
> Write Lock creation
> -----------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-78
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-78
>             Project: Zookeeper
>          Issue Type: New Feature
>          Components: java client
>    Affects Versions: 3.0.0
>            Reporter: james strachan
>            Assignee: james strachan
>             Fix For: 3.2.0
>
>         Attachments: patch_with_including_Benjamin's_fix.patch, 
> using_zookeeper_facade.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch
>
>
> Here's a patch which adds a little WriteLock helper class for performing 
> leader elections or creating exclusive locks in some directory znode. Note 
> its an early cut; am sure we can improve it over time. The aim is to avoid 
> folks having to use the low level ZK stuff but provide a simpler high level 
> abstraction.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to