[
https://issues.apache.org/jira/browse/ZOOKEEPER-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689013#action_12689013
]
Patrick Hunt commented on ZOOKEEPER-60:
---------------------------------------
I think Mahadev's concern is the change:
-#define ZKSERVER_CMD "./tests/zkServer.sh"
+#define ZKSERVER_CMD "zkServer.sh"
unless tests dir is in your path "make run-check" will fail when run directly
in src/c. In
build.xml you are adding tests dir to the PATH, however for someone running
make
directly from src/c this will fail. Also notice that trunk/bin contains a
similarly named
script - so in build.xml you want to prepend the tests directory (zkServer.sh
location)
to the PATH otw it may pickup the wrong script.
Also, the change to config.ac to remove the check for the generated code, why
was this done?
I don't think we should remove this, in case someone runs make directly from
src/c (not build.xml)
Basically we need to ensure that users of both build.xml, and users running
make directly
from src/c, are both able to compile/test successfully.
Perhaps the PATH just needs to be specified when running "make run-check" - ie
update the
PATH in the makefile rather than in the build.xml. I think this would address
the issue for both
users of make and build.xml.
> Get cppunit tests running as part of Hudson CI
> ----------------------------------------------
>
> Key: ZOOKEEPER-60
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-60
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Reporter: Patrick Hunt
> Assignee: Giridharan Kesavan
> Attachments: ZK-60.patch
>
>
> Investigate if it is possible to run cppunit tests as part of Hudson.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
