[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696907#action_12696907
 ] 

Hadoop QA commented on ZOOKEEPER-337:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12404890/ZOOKEEPER-337.patch
  against trunk revision 762602.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 37 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/19/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/19/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/19/console

This message is automatically generated.

> improve logging in leader election lookForLeader method when address 
> resolution fails
> -------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-337
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-337
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: quorum
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-337.patch
>
>
> leader election has the following code:
>                 requestPacket.setSocketAddress(server.addr);
>                 LOG.info("Server address: " + server.addr);
> this should be switched to have the info log first, set sock addr second.
> The reason for this is that if the setSocketAddress fails sun is not printing 
> the address used. As a result it's verfy difficult to debug this issue.
> If we log the server address first, then if the setsockaddr fails we'll see 
> both the address of the server and the exception detail (right now we just 
> see the exception detail which does not include the invlaid address in 
> invalidaddressexception).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to