Mahadev konar updated ZOOKEEPER-78:

    Attachment: ZOOKEEPER-78.patch

this patch should fix most of the issues raised by pat and ben.
you will have to do the following before you can apply the patch -- 

svn move src/c/src/zk_log.h src/c/include/zk_log.h 
the include file is necessary to use LOG_* macros.

 ill just list out what I have fixed in this patch.. 

- improved the docs for recipes amd recipes/lock. both of them have a 
README.txt. the recipes one lists out how to create new recipes and conventions 
to follow. 
- changed the c libary method names to follow the convention
-  renamed the jar file to be zookeeper-version-recipes-name.jar
- for interop I will open another jira
- also we should commit the configure generated after running autoconf. I didnt 
attach it to the patch since it makes it huge.
- cleaned up imports
- modularized the java code 
- i have left the sleep 30 in the c tests. I will open a jira to fix it later.
- i have added logging to the c code.
- improved the javadocs and c doxygen comments to make the return values clearer
- chanegd the version in configure.ac
- the doxygen docs should work now 
- added synchronized for the lock methods both in c and java
- fixed to sleep only on a retyr

I think i might have addressed most of the review issues, but please take a 
look and see if anything still remains. comments are welcome.

> added a high level protocol/feature - for easy Leader Election or exclusive 
> Write Lock creation
> -----------------------------------------------------------------------------------------------
>                 Key: ZOOKEEPER-78
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-78
>             Project: Zookeeper
>          Issue Type: New Feature
>          Components: java client
>    Affects Versions: 3.0.0
>            Reporter: james strachan
>            Assignee: Mahadev konar
>             Fix For: 3.2.0
>         Attachments: patch_with_including_Benjamin's_fix.patch, 
> using_zookeeper_facade.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch, 
> ZOOKEEPER-78.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch, 
> ZOOKEEPER-78.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch
> Here's a patch which adds a little WriteLock helper class for performing 
> leader elections or creating exclusive locks in some directory znode. Note 
> its an early cut; am sure we can improve it over time. The aim is to avoid 
> folks having to use the low level ZK stuff but provide a simpler high level 
> abstraction.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to