Patrick Hunt updated ZOOKEEPER-367:

    Status: Open  (was: Patch Available)

You need try/finally around the operations that might throw exceptions while 
processing the stream(s). The finally needs to close the stream. This will 
handle the case where an exception is thrown while processing the stream - otw 
resources may be leaked.

You might want to run with something like Coverity prevent - it's good at 
flagging this sort of thing.

(I realize the old code didn't handle this properly either, but as you're 
updating the code you should fix it)

> RecoveryTest failure - "unreasonable length" IOException
> --------------------------------------------------------
>                 Key: ZOOKEEPER-367
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-367
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.2.0
>         Environment: ubuntu 8.10 intrpid ibex, jvm 1.6.0_10
>            Reporter: Patrick Hunt
>            Assignee: Mahadev konar
>            Priority: Critical
>             Fix For: 3.2.0
>         Attachments: invalid1.tar.gz, invalidsnap.tar.gz, rec.tar.gz, 
> rep2.tar.gz, TEST-org.apache.zookeeper.test.RecoveryTest.txt, 
> ZOOKEEPER-367.patch, ZOOKEEPER-367.patch
> during local testing I received the attached recoverytest failure

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to