[
https://issues.apache.org/jira/browse/ZOOKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699944#action_12699944
]
Hadoop QA commented on ZOOKEEPER-346:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12405698/ZOOKEEPER-346.patch
against trunk revision 765797.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/35/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/35/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/35/console
This message is automatically generated.
> remove the kill command fro mthe client port.
> ---------------------------------------------
>
> Key: ZOOKEEPER-346
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-346
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.0.0, 3.0.1, 3.1.0
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-346.patch, ZOOKEEPER-346.patch
>
>
> we should just remove the kill command from the client port. Its a security
> risk (though we do not have much security right now) to be able to kill the
> server from a tcp port without any authentication...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
