[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700156#action_12700156
 ] 

Hudson commented on ZOOKEEPER-337:
----------------------------------

Integrated in ZooKeeper-trunk #283 (See 
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/283/])
    . improve logging in leader election lookForLeader method when address 
resolution fails (phunt via mahadev)


> improve logging in leader election lookForLeader method when address 
> resolution fails
> -------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-337
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-337
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: quorum
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-337.patch, ZOOKEEPER-337.patch, 
> ZOOKEEPER-337.patch
>
>
> leader election has the following code:
>                 requestPacket.setSocketAddress(server.addr);
>                 LOG.info("Server address: " + server.addr);
> this should be switched to have the info log first, set sock addr second.
> The reason for this is that if the setSocketAddress fails sun is not printing 
> the address used. As a result it's verfy difficult to debug this issue.
> If we log the server address first, then if the setsockaddr fails we'll see 
> both the address of the server and the exception detail (right now we just 
> see the exception detail which does not include the invlaid address in 
> invalidaddressexception).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to