[
https://issues.apache.org/jira/browse/ZOOKEEPER-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703946#action_12703946
]
Hadoop QA commented on ZOOKEEPER-365:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12406698/ZOOKEEPER-365.patch
against trunk revision 769079.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/54/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/54/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/54/console
This message is automatically generated.
> javadoc is wrong for setLast in LedgerHandle
> --------------------------------------------
>
> Key: ZOOKEEPER-365
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-365
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Flavio Paiva Junqueira
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-365.patch
>
>
> Note: the javadoc is wrong here:
> /**
> * Returns the last entry identifier submitted and increments it.
> * @return long
> */
> long setLast(long last){
> also would be great to have javadoc for the legerrecoverymonitor getNextHint
> method. I was reviewing this code and it would have been helpful to know what
> to expect of this method. (possible return values, etc...)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
