[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705596#action_12705596
 ] 

Flavio Paiva Junqueira commented on ZOOKEEPER-380:
--------------------------------------------------

It looks very good. I just have a few minor comments:

* The increment in LedgerInputStream can be larger, say 100 or even 1000;
* I wonder if LedgerInputStream and LedgerOutputStream should be part of the 
client package. I don't have a strong argument for having this change, but it 
might be better given the organization we have currently;
* I think we should delete org.apache.bookkeeper.client.LedgerStream. Your 
implementation supersedes that one.



> bookkeeper should have a streaming api so that its easier to store 
> checpoints/snapshots in bookkeeper.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-380
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-380
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: contrib-bookkeeper
>    Affects Versions: 3.1.0, 3.1.1
>            Reporter: Mahadev konar
>            Assignee: Mahadev konar
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-380.patch, ZOOKEEPER-380.patch, 
> ZOOKEEPER-380.patch, ZOOKEEPER-380.patch, ZOOKEEPER-380.patch
>
>
> currently, bookkeeper api allows just a bytes interface which is 
> ld.write(bytes).
> We should have an interface like 
> Stream s = ledger.createStream() (I am not very sure of the interface right 
> now but will post a more concrete one after giving it a little more thought)
> now this stream can be used to wirte checkpoints as 
> s.write(bytes)
> and then closed to s.close() to close the snapshot. 
> This api could use the current api to implement snapshots as chunks of bytes 
> (buffered by stream s) that can be written via ld.write(bytes).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to