[
https://issues.apache.org/jira/browse/ZOOKEEPER-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708203#action_12708203
]
Hadoop QA commented on ZOOKEEPER-358:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12407766/ZOOKEEPER-358.patch
against trunk revision 772843.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/68/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/68/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/68/console
This message is automatically generated.
> Throw exception when ledger does not exist
> ------------------------------------------
>
> Key: ZOOKEEPER-358
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-358
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bookkeeper
> Affects Versions: 3.1.1
> Reporter: Luca Telloli
> Assignee: Flavio Paiva Junqueira
> Priority: Minor
> Attachments: ZOOKEEPER-358.patch
>
>
> Currently, openLedger() in the BookKeeper client returns null if the ledger
> ID does not exist on ZK. Maybe it would be better to throw a specific
> exception so it can be handled by the client side.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
