Patrick Hunt updated ZOOKEEPER-410:

    Attachment: ZOOKEEPER-410.patch

I added a few exclusions, with comment. In particular I think we should allow
*Main classes (ie command line tools) to call system exit as necessary (from 
in *Main)

Please review the movement of start() calls in particular.

Also carefully review the locking changes in nioservercnxn (which doesn't seem 
to silence
findbugs, but it seems like it should)

> address all findbugs warnings in client/server classes
> ------------------------------------------------------
>                 Key: ZOOKEEPER-410
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-410
>             Project: Zookeeper
>          Issue Type: Sub-task
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.2.0
>         Attachments: ZOOKEEPER-410.patch
> trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
> trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java
> trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
> trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
> trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
> trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
> trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to