Flavio Paiva Junqueira updated ZOOKEEPER-407:

    Attachment: ZOOKEEPER-407.patch

I'm not 100% sure of what to do with the System.exit calls sprinkled all over 
the code. I'm including some modifications in this patch, but I'm afraid they 
won't replicate the behavior we have currently. In some cases, we might 
consider throwing an exception and let some method higher up in the call path 
decide the appropriate measure. In other cases, like the one of LeaderElection, 
I'm not sure it is really necessary to exit if we can't open the socket. I 
understand it won't work, but perhaps throwing an exception again or simply 
logging a message might do the job. In any case, I have marked the occurrences 
for this package with a "TODO".

I would appreciate some comments on this matter.

> address all findbugs warnings in org.apache.zookeeper.server.quorum.** 
> packages
> -------------------------------------------------------------------------------
>                 Key: ZOOKEEPER-407
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-407
>             Project: Zookeeper
>          Issue Type: Sub-task
>          Components: server
>            Reporter: Patrick Hunt
>            Assignee: Flavio Paiva Junqueira
>             Fix For: 3.2.0
>         Attachments: ZOOKEEPER-407.patch, ZOOKEEPER-407.patch
> Flavio please address the findbugs warnings in quorum and sub packages. See
> http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/308/violations/
> for a list of issues or use ant's findbugs (or eclipse) to identify the 
> issues.
> In general we should try to fix these, but ignoring the warning (annotation) 
> is ok if it includes comments to effect why, also has
>  to be reviewed/approved.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to