[
https://issues.apache.org/jira/browse/ZOOKEEPER-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710794#action_12710794
]
Flavio Paiva Junqueira commented on ZOOKEEPER-407:
--------------------------------------------------
For this patch I'm certainly not proposing that we fix any problem with exit
calls. All modifications I have suggested are to get rid of the findbugs
warnings. In fact, my preference is to leave the exit calls as they are and
perhaps deal with them in a separate jira if there is any need to do so.
> address all findbugs warnings in org.apache.zookeeper.server.quorum.**
> packages
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-407
> Project: Zookeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Patrick Hunt
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-407.patch, ZOOKEEPER-407.patch
>
>
> Flavio please address the findbugs warnings in quorum and sub packages. See
> http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/308/violations/
> for a list of issues or use ant's findbugs (or eclipse) to identify the
> issues.
> In general we should try to fix these, but ignoring the warning (annotation)
> is ok if it includes comments to effect why, also has
> to be reviewed/approved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
