Benjamin Reed updated ZOOKEEPER-410:

    Status: Open  (was: Patch Available)

excellent job pat. my only problem with the patch is that in 
FinalRequestProcessor you have changed the behavior for the case where the 
expected xid is greater than the actual one seen. if the incoming xid is lower 
than expected you lose the outstanding change, which may be the next one in the 
pipe, which will result in another warning and skip, and so on.

> address all findbugs warnings in client/server classes
> ------------------------------------------------------
>                 Key: ZOOKEEPER-410
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-410
>             Project: Zookeeper
>          Issue Type: Sub-task
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.2.0
>         Attachments: ZOOKEEPER-410.patch
> trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
> trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java
> trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
> trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
> trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
> trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
> trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to