Flavio Paiva Junqueira updated ZOOKEEPER-383:

    Attachment: ZOOKEEPER-383.patch

This patch addresses most of the issues raised by Mahadev. I haven't removed 
unused variables or imports because I couldn't see any. 

With respect to the discussion on callbacks, before we didn't have a 
LedgerHandle, but instead only ledger id. I'm fine either way, although I tend 
to agree with Ben that it might be better to have the ledger handle explicitly 
among the input parameters of the callback method.

> Asynchronous version of createLedger()
> --------------------------------------
>                 Key: ZOOKEEPER-383
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-383
>             Project: Zookeeper
>          Issue Type: New Feature
>          Components: contrib-bookkeeper
>            Reporter: Utkarsh Srivastava
>            Assignee: Flavio Paiva Junqueira
>         Attachments: ZOOKEEPER-383.patch, ZOOKEEPER-383.patch, 
> ZOOKEEPER-383.patch, ZOOKEEPER-383.patch
> While there are async versions for read and write, there is no async version 
> for creating a ledger. This can cause applications to have to change their 
> whole thread design. 
> It should be easier and more consistent to add an async version of 
> createLedger().

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to