[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714657#action_12714657
 ] 

Hadoop QA commented on ZOOKEEPER-375:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12409425/ZOOKEEPER-375.patch
  against trunk revision 780122.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/95/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/95/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/95/console

This message is automatically generated.

> zoo_add_auth only retains most recent auth on re-sync
> -----------------------------------------------------
>
>                 Key: ZOOKEEPER-375
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.1.0, 3.1.1
>            Reporter: Patrick Hunt
>            Assignee: Mahadev konar
>            Priority: Blocker
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-375.patch, ZOOKEEPER-375.patch
>
>
> zoo_add_auth doesn't maintain a list of auths - it only stores the most 
> recent auth send to the server. As a result on re-sync to the cluster it will 
> lose (not reregister) any auths prior to the most recent.
> This code should maintain a list of auths similar to the java code. Be sure 
> to free the memory in close.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to