[ https://issues.apache.org/jira/browse/ZOOKEEPER-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714764#action_12714764 ]
Hadoop QA commented on ZOOKEEPER-421: ------------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12409463/ZOOKEEPER-421.patch against trunk revision 780122. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 29 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/98/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/98/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/98/console This message is automatically generated. > zkpython run_tests.sh is missing #! > ----------------------------------- > > Key: ZOOKEEPER-421 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-421 > Project: Zookeeper > Issue Type: Bug > Components: contrib-bindings > Reporter: Patrick Hunt > Assignee: Henry Robinson > Priority: Minor > Attachments: ZOOKEEPER-421.patch, ZOOKEEPER-421.patch > > > the scripts in the test directory of zkpython are missing #! headers > Probably: > #!/bin/sh > for shell scripts and > #!/usr/bin/python > for .py scripts? > Also include a shell script that will svn chmod the *.py scripts so that they > can be executed individually from the command line (shortcut > rather than (python foo.py). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.