Hadoop QA commented on ZOOKEEPER-443:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 783162.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
Findbugs warnings: 
Console output: 

This message is automatically generated.

> trace logging in watch notification not wrapped with istraceneabled - 
> inefficient
> ---------------------------------------------------------------------------------
>                 Key: ZOOKEEPER-443
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-443
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>            Priority: Critical
>             Fix For: 3.2.0
>         Attachments: ZOOKEEPER-443.patch
> In org.apache.zookeeper.server.NIOServerCnxn.process(WatchedEvent) there's a 
> trace message
> that's not wrapped with isTraceEnabled, this is very inefficient and should 
> be fixed.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to