Hadoop QA commented on ZOOKEEPER-447:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 788539.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
Findbugs warnings: 
Console output: 

This message is automatically generated.

> zkServer.sh doesn't allow different config files to be specified on the 
> command line
> ------------------------------------------------------------------------------------
>                 Key: ZOOKEEPER-447
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-447
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.1.1, 3.2.0
>            Reporter: Henry Robinson
>            Assignee: Henry Robinson
>            Priority: Minor
>         Attachments: ZOOKEEPER-447.patch
> Unless I'm missing something, you can change the directory that the zoo.cfg 
> file is in by setting ZOOCFGDIR but not the name of the file itself.
> I find it convenient myself to specify the config file on the command line, 
> but we should also let it be specified by environment variable.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to