Mahadev konar commented on ZOOKEEPER-481:

 I just ran ant test-patch since hudson wastn willing to run it for us.

I fopt a -1 with 

3 new findbugs warnings generated. Can you please try running findbugs and see 
where the issues are? 

> Add lastMessageSent to QuorumCnxManager
> ---------------------------------------
>                 Key: ZOOKEEPER-481
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-481
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: leaderElection
>    Affects Versions: 3.1.1, 3.2.0
>            Reporter: Flavio Paiva Junqueira
>            Assignee: Flavio Paiva Junqueira
>             Fix For: 3.2.1, 3.3.0
>         Attachments: ZOOKEEPER-481-branch3.2.patch, ZOOKEEPER-481.patch, 
> ZOOKEEPER-481.patch, ZOOKEEPER-481.patch
> Currently we rely on TCP for reliable delivery of FLE messages. However, as 
> we concurrently drop and create new connections, it is possible that a 
> message is sent but never received. With this patch, cnx manager keeps a list 
> of last messages sent, and resends the last one sent. Receiving multiples 
> copies is harmless. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to