Hadoop QA commented on ZOOKEEPER-490:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 801839.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
Findbugs warnings: 
Console output: 

This message is automatically generated.

> the java docs for session creation are misleading/incomplete
> ------------------------------------------------------------
>                 Key: ZOOKEEPER-490
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-490
>             Project: Zookeeper
>          Issue Type: Bug
>    Affects Versions: 3.1.1, 3.2.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.2.1, 3.3.0
>         Attachments: ZOOKEEPER-490.patch
> the javadoc for ZooKeeper constructor says:
>      * The client object will pick an arbitrary server and try to connect to 
> it.
>      * If failed, it will try the next one in the list, until a connection is
>      * established, or all the servers have been tried.
> the "or all server tried" phrase is misleading, it should indicate that we 
> retry until success, con closed, or session expired. 
> we also need ot mention that connection is async, that constructor returns 
> immed and you need to look for connection event in watcher

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to