[
https://issues.apache.org/jira/browse/ZOOKEEPER-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748048#action_12748048
]
Mahadev konar commented on ZOOKEEPER-518:
-----------------------------------------
+1 the patch looks good...
> DEBUG message for outstanding proposals in leader should be moved to trace.
> ---------------------------------------------------------------------------
>
> Key: ZOOKEEPER-518
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-518
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.1.1, 3.2.0
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-518.patch
>
>
> this is the code in Leader.java
> {code}
> if (LOG.isDebugEnabled()) {
> LOG.debug("Ack zxid: 0x" + Long.toHexString(zxid));
> for (Proposal p : outstandingProposals.values()) {
> long packetZxid = p.packet.getZxid();
> LOG.debug("outstanding proposal: 0x"
> + Long.toHexString(packetZxid));
> }
> LOG.debug("outstanding proposals all");
> }
> {code}
> We should move this debug to trace since it will cause really high latencies
> in response times from zookeeper servers in case folks want to use DEBUG
> logging for servers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
