[
https://issues.apache.org/jira/browse/ZOOKEEPER-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748205#action_12748205
]
Hadoop QA commented on ZOOKEEPER-518:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12417755/ZOOKEEPER-518.patch
against trunk revision 807484.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/191/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/191/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/191/console
This message is automatically generated.
> DEBUG message for outstanding proposals in leader should be moved to trace.
> ---------------------------------------------------------------------------
>
> Key: ZOOKEEPER-518
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-518
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.1.1, 3.2.0
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-518.patch
>
>
> this is the code in Leader.java
> {code}
> if (LOG.isDebugEnabled()) {
> LOG.debug("Ack zxid: 0x" + Long.toHexString(zxid));
> for (Proposal p : outstandingProposals.values()) {
> long packetZxid = p.packet.getZxid();
> LOG.debug("outstanding proposal: 0x"
> + Long.toHexString(packetZxid));
> }
> LOG.debug("outstanding proposals all");
> }
> {code}
> We should move this debug to trace since it will cause really high latencies
> in response times from zookeeper servers in case folks want to use DEBUG
> logging for servers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
