[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753939#action_12753939
 ] 

Mahadev konar commented on ZOOKEEPER-472:
-----------------------------------------

I htought the jira was just about not instantiating hashmap.. no? Why does 
PersistentNode and Ephemeral node need to be different? They can be the same 
but with the property that until and unless a addchild is done, the hashset 
maps to null... wouldnt that be sufficient?

Even with the above you wont be able to do sorted nodes since the chidlren are 
still sets... no? The children member should map to some other datastructure 
that maintains order.. no?

> Making DataNode not instantiate a HashMap when the node is ephmeral
> -------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-472
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-472
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.1.1, 3.2.0
>            Reporter: Erik Holstad
>            Assignee: Erik Holstad
>            Priority: Minor
>             Fix For: 3.3.0
>
>
> Looking at the code, there is an overhead of a HashSet object for that nodes 
> children, even though the node might be an ephmeral node and cannot have 
> children.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to