[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758145#action_12758145
 ] 

Mahadev konar commented on ZOOKEEPER-529:
-----------------------------------------

this is great... will make our build really clean -- some comments/questions:

- I see changes to 

{code}
--- src/recipes/lock/src/c/tests/zkServer.sh
--- src/contrib/zkpython/src/test/zkServer.sh
{code}
 Doesnt src/c/tests/zkServer.sh need changes? We should combine all these files 
into one, but that is another jira.

- also, I ran the tests twice and it succeded but it left a process running on 
my machine after the tests were done running 
{code}
java -cp 
:../../..//build/classes:../../..//conf:../../..//build/lib/jline-0.9.94.jar:../../..//build/lib/log4j-1.2.15.jar:../../..//src/java/lib/ivy-2.1.0-rc2.jar:../../..//src/java/lib/jline-0.9.94.jar:../../..//src/java/lib/junit-4.4.jar:../../..//src/java/lib/log4j-1.2.15.jar
 org.apache.zookeeper.server.ZooKeeperServerMain 22182 /tmp/zkdata
{code}
 Am not sure that if I accidentally might have killed something or not (both 
times). Ill  re verify this. Do you see any such problem?

Other than that the patch looks good to go... sorry about the delay in 
reviewing... 


> Use Ivy to pull dependencies and also generate pom
> --------------------------------------------------
>
>                 Key: ZOOKEEPER-529
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-529
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: build
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-529.patch, ZOOKEEPER-529.patch, 
> ZOOKEEPER-529.patch
>
>
> Integrate Ivy into the build. Generate Pom and signed jars to allow zk jars 
> to be officially deployed to a maven repo.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to