[
https://issues.apache.org/jira/browse/ZOOKEEPER-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762804#action_12762804
]
Hadoop QA commented on ZOOKEEPER-510:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12421360/ZOOKEEPER-510.patch
against trunk revision 822065.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 25 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/19/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/19/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/19/console
This message is automatically generated.
> zkpython lumps all exceptions as IOError, needs specialized exceptions for
> KeeperException types
> ------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-510
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-510
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Henry Robinson
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-510.patch, ZOOKEEPER-510.patch,
> ZOOKEEPER-510.patch, ZOOKEEPER-510.patch
>
>
> The current zkpython bindings always throw "IOError("text")" exceptions, even
> for ZK specific exceptions such as NODEEXISTS. This makes it difficult (error
> prone) to handle exceptions in python code. You can't easily pickup a
> connection loss vs a node exists for example. Of course you could match the
> error string, but this seems like a bad idea imo.
> We need to add specific exception types to the python binding that map
> directly to KeeperException/java types. It would also be useful to include
> the information provided by the KeeperException (like path in some cases),
> etc... as part of the error thrown to the python code. Would probably be a
> good idea to stay as close to java api as possible wrt mapping the errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
