Patrick Hunt updated ZOOKEEPER-550:

    Status: Open  (was: Patch Available)

Canceling the patch for now, but I'm glad to see additional recipes being 

A few suggestions:

1) we don't allow tabs in the source, please use spaces for indentation 
(eclipse can help with this)
2) please add a  README.txt similar to what's available in the lock recipe. 
this is important to have, otw potential
  users won't know the details on how the queue is being implemented 
(semantics). The lock recipe essentially just
  points to the std recipe docs for example, you probably can do similar if 
your impl is based on the recipe doc.
3) we really want to maintain parity btw java and c, any chance you could 
implement the c recipe as well?

Great to see tests!

Mahadev, it would be good if you could review this give that you implemented 
the lock recipe.

> Java Queue Recipe
> -----------------
>                 Key: ZOOKEEPER-550
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-550
>             Project: Zookeeper
>          Issue Type: New Feature
>          Components: java client
>    Affects Versions: 3.2.1
>            Reporter: Steven Cheng
>            Assignee: Steven Cheng
>            Priority: Minor
>             Fix For: 3.3.0
>         Attachments: ZOOKEEPER-550.patch, ZOOKEEPER-550.patch
> This patch adds a recipe for creating a distributed queue with ZooKeeper 
> similar to the WriteLock recipe and some sequential tests.  This early 
> attempt follows the Java BlockingQueue interface, though it doesn't implement 
> it since I don't think there's a good reason for it to be Iterable.  

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to