[ https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765770#action_12765770 ]
Patrick Hunt commented on ZOOKEEPER-472: ---------------------------------------- Hi Erik, I tried patching the current trunk, but the patch fails (below). Perhaps it's against an older version of zk source? Would you mind creating a patch against the current source HEAD in svn? (I took a look but it seemed more than just a simple mismatch, easiest if you could address) Also it's best to have a single patch file as attachment, all you need to do is upload a file with the same name and jira will take care of it: from howtocontribute: "In some cases a patch may need to be updated based on review comments. In this case the updated patch should be re-attached to the Jira with the same name. Jira will archive the older version of the patch and make the new patch the active patch. This will enable a history of patches on the Jira. As stated above patch naming is generally ZOOKEEPER-#.patch where ZOOKEEPER-# is the id of the Jira." you could use "manage attachments" to address (ie remove the v2.patch) ------------------- patch -p0 < /home/phunt/Desktop/zookeeper-472-v2.patch patching file src/java/main/org/apache/zookeeper/server/DataNode.java patching file src/java/main/org/apache/zookeeper/server/DataTree.java Hunk #35 FAILED at 1029. 1 out of 35 hunks FAILED -- saving rejects to file src/java/main/org/apache/zookeeper/server/DataTree.java.rej patching file src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java Hunk #6 FAILED at 208. 1 out of 9 hunks FAILED -- saving rejects to file src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java.rej > Making DataNode not instantiate a HashMap when the node is ephmeral > ------------------------------------------------------------------- > > Key: ZOOKEEPER-472 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-472 > Project: Zookeeper > Issue Type: Improvement > Components: server > Affects Versions: 3.1.1, 3.2.0 > Reporter: Erik Holstad > Assignee: Erik Holstad > Priority: Minor > Fix For: 3.3.0 > > Attachments: zookeeper-472-v2.patch, zookeeper-472.patch > > > Looking at the code, there is an overhead of a HashSet object for that nodes > children, even though the node might be an ephmeral node and cannot have > children. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.