[
https://issues.apache.org/jira/browse/ZOOKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766087#action_12766087
]
Hadoop QA commented on ZOOKEEPER-555:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12422239/getchildren_stat.patch
against trunk revision 824981.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
-1 patch. The patch command could not apply the patch.
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/27/console
This message is automatically generated.
> Add stat information to GetChildrenResponse
> -------------------------------------------
>
> Key: ZOOKEEPER-555
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-555
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, contrib-bindings, java client, server
> Affects Versions: 3.3.0
> Reporter: Árni Már Jónsson
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: getchildren_stat.patch
>
>
> GetChildren() is the only non-create/delete API which does not include the
> node stat information. I propose that the definition of GetChildren() should
> be:
> class GetChildrenResponse {
> vector<ustring> children;
> org.apache.zookeeper.data.Stat stat;
> }
> There is a trivial fix to the server (FinalRequestProcessor.java): rsp = new
> GetChildrenResponse(children, stat);
> And something similar to the client library.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
