Mahadev konar commented on ZOOKEEPER-472:

 I just tried compiling the code with ant jar and it fails to compile with the 
folowing error -

    [javac] Compiling 104 source files to 
 children has private access in org.apache.zookeeper.server.DataNode
    [javac]                 node.parent.children.add(path.substring(lastSlash + 
    [javac]                            ^
    [javac] 1 error

I havent ahd a chance to review the code yet, but I couldnt help but notice 
changes to license headers on 
src/java/main/org/apache/zookeeper/server/DataNode.java. Is there something you 
changed in the licence?

> Making DataNode not instantiate a HashMap when the node is ephmeral
> -------------------------------------------------------------------
>                 Key: ZOOKEEPER-472
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-472
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.1.1, 3.2.0
>            Reporter: Erik Holstad
>            Assignee: Erik Holstad
>            Priority: Minor
>             Fix For: 3.3.0
>         Attachments: zookeeper-472.patch, zookeeper-472.patch
> Looking at the code, there is an overhead of a HashSet object for that nodes 
> children, even though the node might be an ephmeral node and cannot have 
> children.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to