[ https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766611#action_12766611 ]
Mahadev konar commented on ZOOKEEPER-472: ----------------------------------------- erik, I just tried compiling the code with ant jar and it fails to compile with the folowing error - {code} compile: [javac] Compiling 104 source files to /home/mahadev/workspace/zookeeper-commit-trunk/build/classes [javac] /home/mahadev/workspace/zookeeper-commit-trunk/src/java/main/org/apache/zookeeper/server/DataTree.java:1055: children has private access in org.apache.zookeeper.server.DataNode [javac] node.parent.children.add(path.substring(lastSlash + 1)); [javac] ^ [javac] 1 error {code} I havent ahd a chance to review the code yet, but I couldnt help but notice changes to license headers on src/java/main/org/apache/zookeeper/server/DataNode.java. Is there something you changed in the licence? > Making DataNode not instantiate a HashMap when the node is ephmeral > ------------------------------------------------------------------- > > Key: ZOOKEEPER-472 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-472 > Project: Zookeeper > Issue Type: Improvement > Components: server > Affects Versions: 3.1.1, 3.2.0 > Reporter: Erik Holstad > Assignee: Erik Holstad > Priority: Minor > Fix For: 3.3.0 > > Attachments: zookeeper-472.patch, zookeeper-472.patch > > > Looking at the code, there is an overhead of a HashSet object for that nodes > children, even though the node might be an ephmeral node and cannot have > children. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.