[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774740#action_12774740
 ] 

Hadoop QA commented on ZOOKEEPER-570:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12424290/ZOOKEEPER-570.patch
  against trunk revision 833639.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 5 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/55/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/55/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/55/console

This message is automatically generated.

> AsyncHammerTest is broken, callbacks need to validate rc parameter
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-570
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-570
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>            Priority: Critical
>             Fix For: 3.2.2, 3.3.0
>
>         Attachments: ZOOKEEPER-570.patch
>
>
> the asynchammertest is not validating the rc in the callback, more serious is 
> that it is using path in the create callback
> to delete the node, rather than name (which is important in the case of a 
> sequential node creation as in this case)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to