Mahadev konar commented on ZOOKEEPER-472:

+1 .. the patch looks good. one minor nit for future patches, it becomes hard 
to review the patches if it has a lot of indentation changes. This patch had a 
lot of indentation than code changes and it became quite hard to review. Its 
always good to file indentation changes in a seperate jira so that reviewer can 
easily find out what actual code changes happened.

> Making DataNode not instantiate a HashMap when the node is ephmeral
> -------------------------------------------------------------------
>                 Key: ZOOKEEPER-472
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-472
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.1.1, 3.2.0
>            Reporter: Erik Holstad
>            Assignee: Erik Holstad
>            Priority: Minor
>             Fix For: 3.3.0
>         Attachments: zookeeper-472.patch, zookeeper-472.patch, 
> zookeeper-472.patch, zookeeper-472.patch, zookeeper-472.patch, 
> zookeeper-472.patch
> Looking at the code, there is an overhead of a HashSet object for that nodes 
> children, even though the node might be an ephmeral node and cannot have 
> children.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to