[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-588:
-----------------------------------

    Attachment: ZOOKEEPER-588.patch

fixed the tostring and also addressed a problem in the caller 

1) caller now tries to log the path if it knows it (since we may not be able to 
figure out in req tostring as that's sorta a hack

2) added a few more exceptions to attempts to print reqpath in tostring

3) added more sanity checks before attempting to determine path

4) removed the annoying log message that caused this issue in the first place.

> remove unnecessary/annoying log of tostring error in Request.toString()
> -----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-588
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-588
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Priority: Minor
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-588.patch
>
>
> Why are we logging this? It's unnecessary and just annoying afaict. We should 
> remove it entirely.
> 2009-11-18 05:37:29,312 WARN org.apache.zookeeper.server.Request: Ignoring 
> exception during toString
> java.nio.BufferUnderflowException
>       at java.nio.HeapByteBuffer.get(HeapByteBuffer.java:127)
>       at java.nio.ByteBuffer.get(ByteBuffer.java:675)
>       at org.apache.zookeeper.server.Request.toString(Request.java:199)
>       at java.lang.String.valueOf(String.java:2827)
>       at java.lang.StringBuilder.append(StringBuilder.java:115)
>       at 
> org.apache.zookeeper.server.quorum.CommitProcessor.processRequest(CommitProcessor.java:167)
>       at 
> org.apache.zookeeper.server.quorum.FollowerRequestProcessor.run(FollowerRequestProcessor.java:68)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to