David Bosschaert commented on ZOOKEEPER-425:

Wow - that's excellent! An automated patch review process!
This patch only contains additional attributes to the zookeeper.jar file. The 
best way to write tests for them will be as part of a system test that's using 
the jar as a bundle in a real OSGi container. Does the zookeeper infrastructure 
have such an area?

Another way to write tests would simply be to check that the headers are there. 
This would be easier to do, but it would require that the tests can expect the 
zookeeper.jar file in a well-known location. For this the jar has to be created 
before those tests are run. Is there such a phase in the zookeeper build system?

> Add OSGi metadata to zookeeper.jar
> ----------------------------------
>                 Key: ZOOKEEPER-425
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-425
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: build
>            Reporter: David Bosschaert
>             Fix For: 3.3.0
>         Attachments: buildxmlpatch.patch, MANIFEST.MF, zk_patch3.patch
> After adding OSGi metadata to zookeeper.jar it can be used as both an OSGi 
> bundle as well as an ordinary jar file. 
> In the CXF/DOSGi project the buildsystem does this using the 
> maven-bundle-plugin: 
> http://svn.apache.org/repos/asf/cxf/dosgi/trunk/discovery/distributed/zookeeper-wrapper/pom.xml
> The MANIFEST.MF generated by maven-bundle-plugin is attached to this bug, 
> this works for the CXF/DOSGi project.
> If your buildsystem isn't using maven, I would advise to use bnd 
> (http://www.aqute.biz/Code/Bnd). BND defines its own ant task in which you 
> should be able to use more or less the same instructions as were used in 
> maven:
> <instructions>
>   <Bundle-Name>ZooKeeper bundle</Bundle-Name>
>   <Bundle-Description>This bundle contains the ZooKeeper 
> library</Bundle-Description>
>   <Bundle-SymbolicName>org.apache.hadoop.zookeeper</Bundle-SymbolicName>
>   <Bundle-Version>3.1.1</Bundle-Version>
>   <Import-Package>*</Import-Package>
>   <Export-Package>*;version=3.1.1</Export-Package>
> </instructions>
> Oh and one other thing. Is it really necessary to put the source code in the 
> Jar file too? I would put that in a separate source distribution :)
> See also: 
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/200905.mbox/%3c4a2009b1.3030...@yahoo-inc.com%3e

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to