[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789664#action_12789664
 ] 

Hadoop QA commented on ZOOKEEPER-534:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12426643/ZOOKEEPER-534.patch
  against trunk revision 889848.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 5 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/25/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/25/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/25/console

This message is automatically generated.

> The test target in contib/bookkeeper does not depend on jar target.
> -------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-534
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-534
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: contrib-bookkeeper
>    Affects Versions: 3.2.0, 3.2.1
>            Reporter: Mahadev konar
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-534.patch
>
>
> The test target in contib/bookkeeper does not depend on jar target. So the 
> ant test target gives compilation errors if the main is not compiled which 
> can be prevented if it depends on jar. It can then check if main has been 
> compiled or not and throw out a reasonable error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to