Henry Robinson updated ZOOKEEPER-608:

    Attachment: ZOOKEEPER-608.patch

Patch attached - made the message debug only. 

Rationale: we don't protect against Byzantine failures, which is effectively 
what this tests for, so no point defensively logging an error (even if I made 
it only applicable to ACKs that *are* errors). Better to make it a debug so 
that developers who understand the messages can turn them on when fixing bugs.

No tests in this one - but all tests in trunk pass. 

> Receipt of ACK from observer should not be logged as ERROR
> ----------------------------------------------------------
>                 Key: ZOOKEEPER-608
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-608
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.3.0
>            Reporter: Henry Robinson
>            Assignee: Henry Robinson
>            Priority: Critical
>             Fix For: 3.3.0
>         Attachments: ZOOKEEPER-608.patch
> Observers - in general - don't send ACKs. But a couple of times they need to. 
> Currently, these are all logged as an ERROR, which is wrong. They should at 
> most be WARN (and this would probably be confusing to the user). INFO might 
> be better. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to