[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801159#action_12801159
 ] 

Flavio Paiva Junqueira commented on ZOOKEEPER-608:
--------------------------------------------------

Pat, Henry, I'm confused. Observers really shouldn't send ACKs, and if they do 
we have a bug. If we are seeing many of these, don't we have an issue with the 
observer logic then? Now, the patch is clearly good, my question is if 
receiving ACKs from observers should be really at debug level.

Also, I checked the hudson run that failed, and it seems that it timed out on 
testObserver. Henry is right in that it doesn't seem to be related to his 
patch, but I wonder if we should open a new jira or not. There isn't enough to 
work with other than "testObserver timed out oin hudson".

> Receipt of ACK from observer should not be logged as ERROR
> ----------------------------------------------------------
>
>                 Key: ZOOKEEPER-608
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-608
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.3.0
>            Reporter: Henry Robinson
>            Assignee: Henry Robinson
>            Priority: Critical
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-608.patch
>
>
> Observers - in general - don't send ACKs. But a couple of times they need to. 
> Currently, these are all logged as an ERROR, which is wrong. They should at 
> most be WARN (and this would probably be confusing to the user). INFO might 
> be better. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to