Henry Robinson commented on ZOOKEEPER-608:

Flavio - 

Observers send two ACKs each during the synchronisation protocol with the 
leader. These are legitimate responses so that the Leader can know that they're 
properly synced. We can potentially remove them, but it seems like more trouble 
than it's worth. 

I don't mind removing these debug messages, but I feel like they could be 
helpful if we do some Observers development in the future to verify any changes 
to the protocol. Happy to take them out though.

We can open a JIRA for the testObservers hang, and I will take a look. I can't 
reproduce the failure but if it happens again, it'll be good to have somewhere 
to track it. 


> Receipt of ACK from observer should not be logged as ERROR
> ----------------------------------------------------------
>                 Key: ZOOKEEPER-608
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-608
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.3.0
>            Reporter: Henry Robinson
>            Assignee: Henry Robinson
>            Priority: Critical
>             Fix For: 3.3.0
>         Attachments: ZOOKEEPER-608.patch
> Observers - in general - don't send ACKs. But a couple of times they need to. 
> Currently, these are all logged as an ERROR, which is wrong. They should at 
> most be WARN (and this would probably be confusing to the user). INFO might 
> be better. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to