[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803793#action_12803793
 ] 

Patrick Hunt commented on ZOOKEEPER-543:
----------------------------------------

I don't mind adding this, but aren't we testing this already in our tests? If 
not, wouldn't it be better to add these to existing/new test classes
that are more geared to the specific functionality being tested, rather than to 
some example which may change over time? Or is the
idea to point ppl to this "exampletest" class and therefore use it as a 
teaching aid, rather than just a test? Also, putting into say clienttest
class would enable testing under both standalone & quorum (for example). I 
guess my point is, why specifically "exampletest", rather than
just a test? Perhaps I'm just confused by the naming, again, I think the idea 
of adding more tests to cover things we don't already test
is a good idea so don't want to dis-wade you in general.


> Tests for ZooKeeper examples
> ----------------------------
>
>                 Key: ZOOKEEPER-543
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
>             Project: Zookeeper
>          Issue Type: New Feature
>          Components: tests
>    Affects Versions: 3.3.0
>            Reporter: Steven Cheng
>            Assignee: Steven Cheng
>            Priority: Minor
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the 
> website.  
> Current plan is to test features used in examples using ZooKeeper calls 
> directly.  Another approach would be to make more usable abstractions such as 
> those in src/recipes and test those.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to