Utkarsh Srivastava commented on ZOOKEEPER-507:

Ben, could you explain the change in PerChannelBookieClient.java. As far as I 
could tell, you exchanged the order of 
- initiating a connect, and
- adding operation to pendingops

But since these are done under a lock, and the connect callback grabs the same 
lock, switching this order is immaterial. It shouldn't have fixed anything.

> BookKeeper client re-write
> --------------------------
>                 Key: ZOOKEEPER-507
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: contrib-bookkeeper
>            Reporter: Flavio Paiva Junqueira
>            Assignee: Utkarsh Srivastava
>             Fix For: 3.3.0
>         Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch
> Error handling is far from ideal currently in the BookKeeper client.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to