Mahadev konar updated ZOOKEEPER-413:

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

+1 the patch looks good. I just committed this. thanks pat.

> two flaws need addressing in the c tests that can cause false positive 
> failures
> -------------------------------------------------------------------------------
>                 Key: ZOOKEEPER-413
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-413
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client, tests
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>            Priority: Minor
>             Fix For: 3.3.0
>         Attachments: ZOOKEEPER-413.patch
> 1) createClient in testclient.cc (check all tests) is not correctly waiting 
> for syncconnected to the server
> 2) there are some instances of while(xxx); in the test code, this could cause 
> problems, really we need to
> have some limit on the number of iterations (other than just the test, which 
> may never return false), also the
> loop should have some sort of sleep(100msec) (whatever time) in order to 
> limit cpu use.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to