[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831214#action_12831214
 ] 

Mahadev konar commented on ZOOKEEPER-579:
-----------------------------------------

I get this while running ant test in src/contrib/zkpython:

{noformat}
     [exec] 
======================================================================
     [exec] ERROR: test_multiple_watchers (__main__.CallbackTest)
     [exec] 
----------------------------------------------------------------------
     [exec] Traceback (most recent call last):
     [exec]   File "src/test/callback_test.py", line 130, in 
test_multiple_watchers
     [exec]     self.assertTrue(self.watcher1 and self.watcher2, "One or more 
watchers failed to fire")
     [exec] AttributeError: 'CallbackTest' object has no attribute 'assertTrue'
     [exec] 
     [exec] 
----------------------------------------------------------------------
     [exec] Ran 4 tests in 0.167s
     [exec] 
     [exec] FAILED (errors=1)
     [exec] Running src/test/clientid_test.py
     [exec] .
     [exec] 
----------------------------------------------------------------------
     [exec] Ran 1 test in 0.011s
     [exec] 
     [exec] OK
     [exec] Running src/test/connection_test.py
     [exec]   File "src/test/connection_test.py", line 118
     [exec]     self.assertEqual(True, all( zookeeper.close(h) == zookeeper.OK 
for h in handles ))
     [exec]                                                                     
 ^
     [exec] SyntaxError: invalid syntax
     [exec] Running src/test/create_test.py
     [exec] ....
     [exec] 
----------------------------------------------------------------------
     [exec] Ran 4 tests in 0.072s
     [exec] 
     [exec] OK
     [exec] Running src/test/delete_test.py
     [exec] ..
     [exec] 
----------------------------------------------------------------------
     [exec] Ran 2 tests in 0.046s
     [exec] 
     [exec] OK
     [exec] Running src/test/exists_test.py
     [exec] ...
     [exec] 
----------------------------------------------------------------------
     [exec] Ran 3 tests in 0.062s
     [exec] 
     [exec] OK
     [exec] Running src/test/get_set_test.py
     [exec] ......
     [exec] 
----------------------------------------------------------------------
     [exec] Ran 6 tests in 4.812s
     [exec] 
     [exec] OK

test-stop:

test:

BUILD SUCCESSFUL
Total time: 13 seconds
{noformat}

I see some errors in the output which look a little suspicious, though ant 
declares a successful build. Am I missing something?


> zkpython needs more test coverage for ACL code paths
> ----------------------------------------------------
>
>                 Key: ZOOKEEPER-579
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-579
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: contrib-bindings
>    Affects Versions: 3.2.1
>            Reporter: Henry Robinson
>            Assignee: Henry Robinson
>             Fix For: 3.3.0
>
>         Attachments: zookeeper-579.patch
>
>
> zkpython's tests don't do a good enough job of exercising the ACL code paths. 
> A few new tests that confirm that setACL and friends are working correctly 
> are needed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to