[
https://issues.apache.org/jira/browse/ZOOKEEPER-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841970#action_12841970
]
Hadoop QA commented on ZOOKEEPER-688:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12438030/ZOOKEEPER-688.patch
against trunk revision 919280.
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that
doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/128/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/128/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/128/console
This message is automatically generated.
> explain session expiration better in the docs & faq
> ---------------------------------------------------
>
> Key: ZOOKEEPER-688
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-688
> Project: Zookeeper
> Issue Type: Bug
> Components: documentation
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-688.patch
>
>
> We are not clear enough (and the diagram we do have seems misleading) on
> _when_ session expirations are generated. In particular the fact that you
> only get expirations when the client is connected to the cluster, not when
> disconnected.
> we need to detail:
> 1) when do you get expiration
> 2) what is the sequence of events that the watcher sees, from disco state, to
> getting the expiration (say the expiration happens when the client is disco,
> what do you see in the watcher while you are getting reconnected)
> 3) we need to give some examples of how to test this. We should be explicit
> that "pulling the network cable" on the client will not show expiration since
> the cliient will not be reconnected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
