Hadoop QA commented on ZOOKEEPER-511:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 919640.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
Findbugs warnings: 
Console output: 

This message is automatically generated.

> bad error handling in FollowerHandler.sendPackets
> -------------------------------------------------
>                 Key: ZOOKEEPER-511
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-511
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: quorum, server
>    Affects Versions: 3.2.0
>            Reporter: Patrick Hunt
>            Assignee: Mahadev konar
>             Fix For: 3.3.0
>         Attachments: ZOOKEEPER-511.patch
> in FollowerHandler if sendPackets gets an ioexception on writeRecord the send 
> thread will exit, however the 
> socket isn't necessarily closed.
> 2009-08-19 15:28:46,869 - WARN  [Sender-/] 
> - Unexpected exception
>       at 
> org.apache.zookeeper.server.quorum.FollowerHandler.sendPackets(FollowerHandler.java:128)
>       at 
> org.apache.zookeeper.server.quorum.FollowerHandler.access$0(FollowerHandler.java:107)
>       at 
> org.apache.zookeeper.server.quorum.FollowerHandler$1.run(FollowerHandler.java:325)
> This results in the follower taking a very long time to recover and rejoin 
> the quorum.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to