[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842187#action_12842187
 ] 

Hadoop QA commented on ZOOKEEPER-622:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12437783/ZOOKEEPER-622.patch
  against trunk revision 919640.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/132/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/132/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/132/console

This message is automatically generated.

> Test for pending watches in send_set_watches should be moved
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-622
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-622
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>            Reporter: Steven Cheng
>            Assignee: Benjamin Reed
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-622.patch, ZOOKEEPER-622.patch, 
> ZOOKEEPER-622.patch, ZOOKEEPER-622.patch
>
>
> Valgrind found:
> {quote}
> ==2357== Conditional jump or move depends on uninitialised value(s)
> ==2357==    at 0x807FDCA: check_events (zookeeper.c:1180)
> ==2357==    by 0x808043A: zookeeper_process (zookeeper.c:1775)
> ==2357==    by 0x806A21B: Zookeeper_close::testCloseConnected1() 
> (TestZookeeperClose.cc:161)
> ==2357==    by 0x806C6BF: CppUnit::TestCaller<Zookeeper_close>::runTest() 
> (TestCaller.h:166)
> {quote}
> zookeeper.c:1180 was the first if in send_set_watches.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to