[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843821#action_12843821
 ] 

Hadoop QA commented on ZOOKEEPER-696:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12438453/ZOOKEEPER-696.patch
  against trunk revision 921509.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/138/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/138/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/138/console

This message is automatically generated.

> NPE in the hudson logs, seems nioservercnxn closed twice
> --------------------------------------------------------
>
>                 Key: ZOOKEEPER-696
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-696
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>            Priority: Blocker
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-696.patch
>
>
> seeing the following on the console for 
> http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/729/
> looks like the cnxn is closed twice? (the second time 'sock' is null). 
> perhaps it's due to client closing and sending session term, then closing 
> socket, server sees the read return -1, so closes cnxn, then sees the session 
> close request (which was queued)?
>     [junit] 2010-03-10 03:15:53,205 - INFO  [main:nioserverc...@1232] - 
> Closed socket connection for client /127.0.0.1:41285 which had sessionid 
> 0x127461233fc0000
>     [junit] 2010-03-10 03:15:53,206 - WARN  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:nioservercnxn$fact...@269] - 
> Ignoring unexpected runtime exception
>     [junit] java.lang.NullPointerException
>     [junit]   at 
> org.apache.zookeeper.server.NIOServerCnxn.close(NIOServerCnxn.java:1232)
>     [junit]   at 
> org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:594)
>     [junit]   at 
> org.apache.zookeeper.server.NIOServerCnxn$Factory.run(NIOServerCnxn.java:259)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to