[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846355#action_12846355
 ] 

Flavio Paiva Junqueira commented on ZOOKEEPER-436:
--------------------------------------------------

Thanks for the new patch, Erwin. A couple of quick comments:

# There are several formatting changes in the patch unrelated to the issue, 
which is distracting;
# Although the patch applies, it does not compile. I get the following 
compilation error, which is not difficult to fix:

{noformat}
  [javac] 
zookeeper-apache-436/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/util/LocalBookKeeper.java:136:
 cannot find symbol
    [javac] symbol  : constructor BookieServer(int,java.io.File,java.io.File[])
    [javac] location: class org.apache.bookkeeper.proto.BookieServer
    [javac]                     bs[i] = new BookieServer(initialPort + i, 
tmpDirs[i], new File[]{tmpDirs[i]});
{noformat}

> Bookies should auto register to ZooKeeper
> -----------------------------------------
>
>                 Key: ZOOKEEPER-436
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: contrib-bookkeeper
>            Reporter: Benjamin Reed
>         Attachments: ZOOKEEPER-436.patch
>
>
> currently bookies have to be manually added to ZooKeeper to be used in a 
> BookKeeper service. we should be able to just start up a bookkie, point it at 
> ZooKeeper, and have it get auto integrated in.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to