Hadoop QA commented on ZOOKEEPER-724:

+1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 925362.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 217 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
Findbugs warnings: 
Console output: 

This message is automatically generated.

> Improve junit test integration - log harness information
> --------------------------------------------------------
>                 Key: ZOOKEEPER-724
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-724
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: tests
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.4.0
>         Attachments: ZOOKEEPER-724.patch
> Currently we have ad-hoc logging (log4j) of setup/teardown and test 
> start/end. Without this information it's often difficult to determine
> what's going on (major milestones) in the logs relative to the tests 
> performed.
> In junit 4.x "@Rule" annotations have been added that allow this to be done 
> much more easily. This patch will add this.
> In particular we can access the test name easily during setup/teardown and 
> the test itself. Additionally we can log more information on
> success/failure of each test.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to