Henry Robinson commented on ZOOKEEPER-631:

The existing tests are the ones that validate this patch. To test the Py_None 
and memory allocation issues is hard because in the first case the GC behaviour 
is hard to force and in the second we would have to stub out calloc(..) somehow!

> zkpython's C code could do with a style clean-up
> ------------------------------------------------
>                 Key: ZOOKEEPER-631
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-631
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: contrib-bindings
>            Reporter: Henry Robinson
>            Assignee: Henry Robinson
>            Priority: Minor
>         Attachments: ZOOKEEPER-631.patch
> Inconsistent formatting / use of parenthesis / some error checking - all need 
> fixing. 
> Also, the documentation in the header file could do with a reformat. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to