[ https://issues.apache.org/jira/browse/ZOOKEEPER-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859637#action_12859637 ]
Hadoop QA commented on ZOOKEEPER-747: ------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12442508/ZOOKEEPER-747.patch against trunk revision 934312. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 5 new Findbugs warnings. -1 release audit. The applied patch generated 25 release audit warnings (more than the trunk's current 24 warnings). -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/63/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/63/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/63/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/63/console This message is automatically generated. > Add C# generation to Jute > ------------------------- > > Key: ZOOKEEPER-747 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-747 > Project: Zookeeper > Issue Type: New Feature > Reporter: Eric Hauser > Attachments: ZOOKEEPER-747.patch > > > The following patch adds a new language, C#, to the Jute code generation. > The code that is generated does have a dependency on a third party library, > Jon Skeet's MiscUtil, which is Apache licensed. The library is necessary > because C# does not provide big endian support in the base class libraries. > As none of the existing Jute code has any unit tests, I have not added tests > for this patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.